zgaetano/datarhei-dragonfork-core
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases 4 Packages Wiki Activity Actions

fix(webrtc): make WebRTC FFmpeg stream maps configurable (closes #2) #6

Closed
zgaetano wants to merge 0 commits from fix/issue-2-configurable-map into m2-webrtc-core-integration
pull from: fix/issue-2-configurable-map
merge into: zgaetano:m2-webrtc-core-integration
Conversation 1 Commits - Files changed -
zgaetano commented 2026-05-03 08:11:02 -04:00
Owner
Copy link

Closes #2.

BuildArgs had -map 0:v:0 / -map 0:a:0 baked in. That's correct for the production case (RTMP / SRT publishers send AV combined on input #0), but it wedges any process whose audio lives elsewhere — multi-input lavfi test scaffolds, multi-camera switches, SDI + separate file-audio.

ConfigWebRTC (and its API DTO twin) now expose VideoMap and AudioMap. Empty strings still mean the old defaults, so existing deployments are untouched.

Tests

TestBuildArgs_DefaultMaps                   ← locks the empty-string default
TestBuildArgs_CustomMaps                    ← drives the multi-input override
TestProcessConfigWebRTCMapsRoundtrip        ← DTO carries the new fields end to end

All race-clean: go test -race ./app/webrtc/... ./http/api/... ./restream/... green.

Stacks

Targets m2-webrtc-core-integration so it lands without depending on the M3 PR (#5). Once M2 lands on main, this can be rebased trivially.

Co-authored with Claude Opus 4.7.

Closes #2. `BuildArgs` had `-map 0:v:0` / `-map 0:a:0` baked in. That's correct for the production case (RTMP / SRT publishers send AV combined on input #0), but it wedges any process whose audio lives elsewhere — multi-input lavfi test scaffolds, multi-camera switches, SDI + separate file-audio. `ConfigWebRTC` (and its API DTO twin) now expose `VideoMap` and `AudioMap`. Empty strings still mean the old defaults, so existing deployments are untouched. ## Tests ``` TestBuildArgs_DefaultMaps ← locks the empty-string default TestBuildArgs_CustomMaps ← drives the multi-input override TestProcessConfigWebRTCMapsRoundtrip ← DTO carries the new fields end to end ``` All race-clean: `go test -race ./app/webrtc/... ./http/api/... ./restream/...` green. ## Stacks Targets `m2-webrtc-core-integration` so it lands without depending on the M3 PR (#5). Once M2 lands on `main`, this can be rebased trivially. Co-authored with Claude Opus 4.7.
zgaetano added 1 commit 2026-05-03 08:11:02 -04:00
fix(webrtc): make WebRTC FFmpeg stream maps configurable (closes #2)
Some checks failed
tests / build (push) Failing after 2s
Details
tests / build (pull_request) Failing after 1s
Details
49677fbd3d 
BuildArgs hardcoded -map 0✌️0 / -map 0🅰️0 for the two RTP legs.
Correct for production RTMP/SRT publishers (single combined input),
but breaks any process whose audio lives on a different input index
— multi-input lavfi test scaffolds, multi-camera pipelines, SDI +
file-audio mixes, etc.

Adds VideoMap and AudioMap fields to ConfigWebRTC (and the API DTO),
defaulting to the prior literals so existing deployments are
unaffected. BuildArgs reads them.

Tests:
- TestBuildArgs_DefaultMaps locks the empty-string default behavior
- TestBuildArgs_CustomMaps drives the multi-input override path
- TestProcessConfigWebRTCMapsRoundtrip extends the DTO roundtrip

Closes #2.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
zgaetano commented 2026-05-03 08:28:57 -04:00
Author
Owner
Copy link

Merged into main via direct push as part of the v0.1.0-dragonfork release. Branch commits are reachable from main; closing this PR. Release: https://forge.wilddragon.net/zgaetano/datarhei-dragonfork-core/releases/tag/v0.1.0-dragonfork

Merged into `main` via direct push as part of the v0.1.0-dragonfork release. Branch commits are reachable from main; closing this PR. Release: https://forge.wilddragon.net/zgaetano/datarhei-dragonfork-core/releases/tag/v0.1.0-dragonfork
zgaetano closed this pull request 2026-05-03 08:28:57 -04:00
Some checks failed
tests / build (push) Failing after 2s
Details
tests / build (pull_request) Failing after 1s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: zgaetano/datarhei-dragonfork-core#6
No description provided.
Delete branch "fix/issue-2-configurable-map"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?