BUG: `POST /assets` body param `sourceType`, `needsProxy` documented but unused #64

New issue

Closed

opened 2026-05-25 03:28:46 -04:00 by zgaetano · 1 comment

zgaetano commented

2026-05-25 03:28:46 -04:00

Owner

Fixed in current main — sourceType now drives media_type (audio vs video), needsProxy=false short-circuits the proxy queue when a proxy key is already present. See services/mam-api/src/routes/assets.js:126-200.

Fixed in current `main` — `sourceType` now drives `media_type` (audio vs video), `needsProxy=false` short-circuits the proxy queue when a proxy key is already present. See `services/mam-api/src/routes/assets.js:126-200`.

zgaetano referenced this issue from a commit

2026-05-26 10:10:49 -04:00

fix: close all 24 open issues (#40–#94)

zgaetano commented

2026-05-26 19:40:22 -04:00

Author

Owner

Fix Plan — #64 sourceType, needsProxy params documented but unused

Root cause: POST /assets destructures only projectId, binId, clipName, hiresKey, proxyKey, duration, capturedAt. Any sourceType or needsProxy fields silently ignored.

Fix: Either:

Handle these fields in the INSERT (add columns or use them to set defaults)
Return 400 for unrecognized fields (strict validation)

Files: src/routes/assets.js POST handler
Effort: ~30min
**Priority: P3 — API correctness

## Fix Plan — #64 sourceType, needsProxy params documented but unused **Root cause:** POST /assets destructures only projectId, binId, clipName, hiresKey, proxyKey, duration, capturedAt. Any sourceType or needsProxy fields silently ignored. **Fix:** Either: 1. Handle these fields in the INSERT (add columns or use them to set defaults) 2. Return 400 for unrecognized fields (strict validation) **Files:** src/routes/assets.js POST handler **Effort:** ~30min **Priority: P3 — API correctness

zgaetano closed this issue

2026-05-26 22:00:47 -04:00