BUG: Asset copy duplicates proxy+thumbnail S3 refs — no S3 copy done #60

New issue

Closed

opened 2026-05-25 02:56:35 -04:00 by zgaetano · 1 comment

zgaetano commented

2026-05-25 02:56:35 -04:00

Owner

Fixed — POST /api/v1/assets/:id/copy now nulls proxy_s3_key and thumbnail_s3_key on the new row, sets status='processing', and re-queues a proxy generation against the original source. The copy gets its own proxy + thumbnail. See services/mam-api/src/routes/assets.js:301-345.

Fixed — `POST /api/v1/assets/:id/copy` now nulls `proxy_s3_key` and `thumbnail_s3_key` on the new row, sets `status='processing'`, and re-queues a proxy generation against the original source. The copy gets its own proxy + thumbnail. See `services/mam-api/src/routes/assets.js:301-345`.

zgaetano referenced this issue from a commit

2026-05-26 10:10:49 -04:00

fix: close all 24 open issues (#40–#94)

zgaetano commented

2026-05-26 19:37:34 -04:00

Author

Owner

Fix Plan — #60 Asset copy duplicates S3 refs

Root cause: POST /:id/copy in assets.js copies proxy_s3_key and thumbnail_s3_key from source to new asset row, but does NOT copy actual S3 objects. Both assets reference same keys. Delete one with hard=true → S3 objects deleted → other asset URLs break.

Fix (choose one):

Option A (deep copy): After copying asset row, copy S3 objects with new keys. Use s3Client.copyObject() to create independent copies, update new asset row with new keys.

Option B (regenerate): Set proxy/thumbnail keys to NULL on copy, queue regeneration via BullMQ proxy and thumbnail queues.

Option C (shared refs, no delete): Allow shared refs but skip S3 delete when other assets reference same key. Requires a ref-count column on S3 keys.

Files: src/routes/assets.js (copy handler)
Effort: ~1.5h
**Priority: P2 — data integrity

## Fix Plan — #60 Asset copy duplicates S3 refs **Root cause:** POST /:id/copy in assets.js copies proxy_s3_key and thumbnail_s3_key from source to new asset row, but does NOT copy actual S3 objects. Both assets reference same keys. Delete one with hard=true → S3 objects deleted → other asset URLs break. **Fix (choose one):** **Option A (deep copy):** After copying asset row, copy S3 objects with new keys. Use s3Client.copyObject() to create independent copies, update new asset row with new keys. **Option B (regenerate):** Set proxy/thumbnail keys to NULL on copy, queue regeneration via BullMQ proxy and thumbnail queues. **Option C (shared refs, no delete):** Allow shared refs but skip S3 delete when other assets reference same key. Requires a ref-count column on S3 keys. **Files:** src/routes/assets.js (copy handler) **Effort:** ~1.5h **Priority: P2 — data integrity

zgaetano closed this issue

2026-05-26 22:01:29 -04:00