node-agent on zampp2: redundant + dead env vars in .env.worker #127

New issue

Closed

opened 2026-05-26 18:22:17 -04:00 by zgaetano · 1 comment

zgaetano commented

2026-05-26 18:22:17 -04:00

Owner

Closed in 1.2.0 ship prep.

onboard-node.sh rewrites .env.worker from scratch on every run with only the live vars actually consumed by index.js and docker-compose.worker.yml. Stale entries from older deploys get wiped on re-onboard.

Also addressed #109 in the same change: BMD_COUNT override now uses BMD_DEVICE_PREFIX (default dv, set io for DeckLink IO/Quad) instead of hardcoding /dev/blackmagic/dv${i}.

Re-run on zampp2:

deploy/onboard-node.sh

Closed in 1.2.0 ship prep. `onboard-node.sh` rewrites `.env.worker` from scratch on every run with only the live vars actually consumed by `index.js` and `docker-compose.worker.yml`. Stale entries from older deploys get wiped on re-onboard. Also addressed #109 in the same change: `BMD_COUNT` override now uses `BMD_DEVICE_PREFIX` (default `dv`, set `io` for DeckLink IO/Quad) instead of hardcoding `/dev/blackmagic/dv${i}`. Re-run on zampp2: ``` deploy/onboard-node.sh ```

~~zgaetano referenced this issue 2026-05-26 18:22:49 -04:00~~

Tracker: 2026-05-26 audit session — 27 bugs logged (#100-#127) #128

zgaetano commented

2026-05-26 19:34:06 -04:00

Author

Owner

Fix Plan — #127 Redundant + dead env vars in zampp2 .env.worker

Root cause: zampp2 .env.worker has:

NODE_IP=172.18.91.217 (stale bridge IP) + NODE_IP=172.18.91.200 (dup, second wins)
GPU_COUNT=1 (blocks nvidia-smi enrichment — see #108)
BMD_COUNT=4 (OK but wrong paths — see #109)
BMD_DEVICE_0..3 (dead code — node-agent never reads these)

Fix:

Remove duplicate NODE_IP — keep only 172.18.91.200
Remove GPU_COUNT=1 (after #108 fix)
Remove BMD_DEVICE_* from .env.example (or wire them up)
Keep BMD_COUNT=4 until #109 fix lands

Files: .env.worker on zampp2, .env.example in repo
Effort: ~15min
**Priority: P3 — cleanup, depends on #108 + #109

## Fix Plan — #127 Redundant + dead env vars in zampp2 .env.worker **Root cause:** zampp2 `.env.worker` has: - `NODE_IP=172.18.91.217` (stale bridge IP) + `NODE_IP=172.18.91.200` (dup, second wins) - `GPU_COUNT=1` (blocks nvidia-smi enrichment — see #108) - `BMD_COUNT=4` (OK but wrong paths — see #109) - `BMD_DEVICE_0..3` (dead code — node-agent never reads these) **Fix:** 1. Remove duplicate `NODE_IP` — keep only `172.18.91.200` 2. Remove `GPU_COUNT=1` (after #108 fix) 3. Remove `BMD_DEVICE_*` from `.env.example` (or wire them up) 4. Keep `BMD_COUNT=4` until #109 fix lands **Files:** `.env.worker` on zampp2, `.env.example` in repo **Effort:** ~15min **Priority: P3 — cleanup, depends on #108 + #109

zgaetano referenced this issue

2026-05-26 19:42:16 -04:00

Tracker: 2026-05-26 audit session — 27 bugs logged (#100-#127) #128

zgaetano closed this issue

2026-05-26 21:21:28 -04:00

zgaetano referenced this issue from a commit

2026-05-26 22:06:25 -04:00

chore: 1.2 ship-prep sweep — close 38 issues