Frontend: 13 stray console.error / console.warn calls in production JSX #123

New issue

Closed

opened 2026-05-26 18:21:54 -04:00 by zgaetano · 1 comment

zgaetano commented

2026-05-26 18:21:54 -04:00

Owner

Fixed in 04ce096. New window.DF_LOG.{debug,warn,error} helper in data.jsx: warn/debug are gated behind ?debug=1, localStorage.df_debug=1, or localhost. Editor + ingest screens converted their stray console.warn / console.error calls to DF_LOG.warn. Critical errors (player MediaError, app load failure, S3 settings load failure) keep console.error.

Fixed in 04ce096. New `window.DF_LOG.{debug,warn,error}` helper in `data.jsx`: warn/debug are gated behind `?debug=1`, `localStorage.df_debug=1`, or `localhost`. Editor + ingest screens converted their stray `console.warn` / `console.error` calls to `DF_LOG.warn`. Critical errors (player MediaError, app load failure, S3 settings load failure) keep `console.error`.

~~zgaetano referenced this issue 2026-05-26 18:22:49 -04:00~~

Tracker: 2026-05-26 audit session — 27 bugs logged (#100-#127) #128

zgaetano commented

2026-05-26 19:36:13 -04:00

Author

Owner

Fix Plan — #123 Stray console.error/warn in production JSX

Root cause: 13 console.error/console.warn calls left in production JSX. Leak internal details to browser console.

Locations: screens-editor.jsx:108,128,140,149,165,214,248,295,325,661, screens-asset.jsx:395, screens-ingest.jsx:509, app.jsx:24.

Fix — wire toast into error handling:

// Replace:
console.error("Failed to load asset:", err);

// With:
window.dispatchEvent(new CustomEvent("df:toast", {
  detail: { message: "Failed to load asset", type: "danger" }
}));

Ensure shell.jsx listens for df:toast and renders a toast notification component.

Files: screens-editor.jsx, screens-asset.jsx, screens-ingest.jsx, app.jsx, shell.jsx
Effort: ~1h
**Priority: P3 — polish

## Fix Plan — #123 Stray console.error/warn in production JSX **Root cause:** 13 `console.error`/`console.warn` calls left in production JSX. Leak internal details to browser console. **Locations:** `screens-editor.jsx:108,128,140,149,165,214,248,295,325,661`, `screens-asset.jsx:395`, `screens-ingest.jsx:509`, `app.jsx:24`. **Fix — wire toast into error handling:** ```js // Replace: console.error("Failed to load asset:", err); // With: window.dispatchEvent(new CustomEvent("df:toast", { detail: { message: "Failed to load asset", type: "danger" } })); ``` Ensure `shell.jsx` listens for `df:toast` and renders a toast notification component. **Files:** `screens-editor.jsx`, `screens-asset.jsx`, `screens-ingest.jsx`, `app.jsx`, `shell.jsx` **Effort:** ~1h **Priority: P3 — polish

zgaetano referenced this issue

2026-05-26 22:02:13 -04:00

[Low] Recorder polling spams 401s on unauthenticated tabs #55

zgaetano referenced this issue from a commit

2026-05-26 22:06:25 -04:00

chore: 1.2 ship-prep sweep — close 38 issues

zgaetano closed this issue

2026-05-26 22:08:13 -04:00