Backend: GET /recorders fires unbounded concurrent Docker API + PG calls (N+1) #121

New issue

Closed

opened 2026-05-26 18:21:19 -04:00 by zgaetano · 1 comment

zgaetano commented

2026-05-26 18:21:19 -04:00

Owner

Fixed in 04ce096. GET /recorders now resolves live_asset_id for every recording row in a single LATERAL JOIN, and Docker container inspects are bounded to actually-recording rows and run in parallel with the existing 10 s dockerApi timeout.

Fixed in 04ce096. `GET /recorders` now resolves `live_asset_id` for every recording row in a single LATERAL JOIN, and Docker container inspects are bounded to actually-recording rows and run in parallel with the existing 10 s `dockerApi` timeout.

~~zgaetano referenced this issue 2026-05-26 18:22:49 -04:00~~

Tracker: 2026-05-26 audit session — 27 bugs logged (#100-#127) #128

zgaetano commented

2026-05-26 19:32:01 -04:00

Author

Owner

Fix Plan — #121 GET /recorders N+1 Docker/PG calls

Root cause: recorders.js:198-202 — Promise.all over every recording-status recorder makes N concurrent Docker API + N concurrent PG queries. No concurrency budget. 20+ recorders → starves Docker socket + PG pool.

Fix — add p-limit:

import pLimit from "p-limit";
const limit = pLimit(4);

// before:
const statuses = await Promise.all(recorders.map(r => dockerApi("GET", `/containers/${r.container_id}/status`)));

// after:
const statuses = await Promise.all(
  recorders.map(r => limit(() => dockerApi("GET", `/containers/${r.container_id}/status`)))
);

Files: src/routes/recorders.js:198-202, package.json
Effort: ~1h
**Priority: P1 — performance

## Fix Plan — #121 GET /recorders N+1 Docker/PG calls **Root cause:** `recorders.js:198-202` — `Promise.all` over every `recording`-status recorder makes N concurrent Docker API + N concurrent PG queries. No concurrency budget. 20+ recorders → starves Docker socket + PG pool. **Fix — add p-limit:** ```js import pLimit from "p-limit"; const limit = pLimit(4); // before: const statuses = await Promise.all(recorders.map(r => dockerApi("GET", `/containers/${r.container_id}/status`))); // after: const statuses = await Promise.all( recorders.map(r => limit(() => dockerApi("GET", `/containers/${r.container_id}/status`))) ); ``` **Files:** `src/routes/recorders.js:198-202`, `package.json` **Effort:** ~1h **Priority: P1 — performance

zgaetano referenced this issue

2026-05-26 21:26:06 -04:00

BUG: recorders.js dockerApi has no socket timeout — hung Docker socket blocks recorder start/stop indefinitely #91

zgaetano referenced this issue from a commit

2026-05-26 22:06:25 -04:00

chore: 1.2 ship-prep sweep — close 38 issues

zgaetano closed this issue

2026-05-26 22:08:19 -04:00