Frontend: EditorKeyboard crash on document.activeElement = null #116

New issue

Closed

opened 2026-05-26 18:20:47 -04:00 by zgaetano · 1 comment

zgaetano commented

2026-05-26 18:20:47 -04:00

Owner

Fixed in 04ce096. EditorKeyboard now does (document.activeElement && document.activeElement.tagName) || '' so iframe focus, popovers, and devtools-driven focus loss no longer crash the handler.

Fixed in 04ce096. `EditorKeyboard` now does `(document.activeElement && document.activeElement.tagName) || ''` so iframe focus, popovers, and devtools-driven focus loss no longer crash the handler.

~~zgaetano referenced this issue 2026-05-26 18:22:49 -04:00~~

Tracker: 2026-05-26 audit session — 27 bugs logged (#100-#127) #128

zgaetano commented

2026-05-26 19:32:01 -04:00

Author

Owner

Fix Plan — #116 EditorKeyboard crash on document.activeElement = null

Root cause: screens-editor.jsx:711 reads document.activeElement.tagName without null guard. document.activeElement is null in iframes after focus loss → TypeError nukes editor keyboard input.

Fix — one line:

// before:
const tag = document.activeElement.tagName;

// after:
const tag = document.activeElement?.tagName;

Files: screens-editor.jsx:711
Effort: 5min
**Priority: P1 — crash fix

## Fix Plan — #116 EditorKeyboard crash on document.activeElement = null **Root cause:** `screens-editor.jsx:711` reads `document.activeElement.tagName` without null guard. `document.activeElement` is null in iframes after focus loss → TypeError nukes editor keyboard input. **Fix — one line:** ```js // before: const tag = document.activeElement.tagName; // after: const tag = document.activeElement?.tagName; ``` **Files:** `screens-editor.jsx:711` **Effort:** 5min **Priority: P1 — crash fix

zgaetano referenced this issue

2026-05-26 19:42:16 -04:00

Tracker: 2026-05-26 audit session — 27 bugs logged (#100-#127) #128

zgaetano referenced this issue from a commit

2026-05-26 22:06:25 -04:00

chore: 1.2 ship-prep sweep — close 38 issues

zgaetano closed this issue

2026-05-26 22:08:49 -04:00