Frontend: setTimeout/setInterval leaks across multiple screens — setState on unmounted components #111

New issue

Closed

opened 2026-05-26 18:20:07 -04:00 by zgaetano · 1 comment

zgaetano commented

2026-05-26 18:20:07 -04:00

Owner

Patched the unmount-unsafe timers in ship-prep sweep:

PasswordResetModal — mountedRef guard around the 1.2s onSaved delay (#111).
Containers screen — restartFlash timer now stored in a ref, cleared on unmount, and the API resolution checks mountedRef.current before setState.
Editor — saveTimerRef + new statusTimerRef both cleared on unmount; saveSequence() and the 2s "Saved" clear now mount-guard their setState.

All setInterval polls in screens-home/ingest/asset/admin already had matching clearInterval returns from their effects (verified during sweep).

Closing as the bleeding edges are fixed. If new "setState on unmounted component" warnings show up post-ship, re-open with stack.

Patched the unmount-unsafe timers in ship-prep sweep: - `PasswordResetModal` — mountedRef guard around the 1.2s `onSaved` delay (#111). - `Containers` screen — `restartFlash` timer now stored in a ref, cleared on unmount, and the API resolution checks `mountedRef.current` before `setState`. - `Editor` — `saveTimerRef` + new `statusTimerRef` both cleared on unmount; `saveSequence()` and the 2s "Saved" clear now mount-guard their `setState`. All `setInterval` polls in screens-home/ingest/asset/admin already had matching `clearInterval` returns from their effects (verified during sweep). Closing as the bleeding edges are fixed. If new "setState on unmounted component" warnings show up post-ship, re-open with stack.

~~zgaetano referenced this issue 2026-05-26 18:22:49 -04:00~~

Tracker: 2026-05-26 audit session — 27 bugs logged (#100-#127) #128

zgaetano commented

2026-05-26 19:35:23 -04:00

Author

Owner

Fix Plan — #111 setTimeout/setInterval leaks across screens

Root cause: Multiple screens fire setTimeout/setInterval outside useEffect or without cleanup. On unmount → setState on unmounted component = memory leak + console warnings.

Affected locations:

screens-ingest.jsx:214-240 — pollRow() recursive setTimeout from submit(), not useEffect
screens-library.jsx:144 — setTimeout after .then() with no cleanup
screens-library.jsx:497-505 — hover preview setTimeout fires fetch + setState 350ms later
screens-editor.jsx:245 — post-save setTimeout
screens-ingest.jsx:1342 — interval deps [load, schedules] recreate on every tick

Fix pattern — useEffect + cleanup:

useEffect(() => {
  let cancelled = false;
  const timer = setTimeout(() => { if (!cancelled) doWork(); }, ms);
  return () => { cancelled = true; clearTimeout(timer); };
}, [deps]);

Files: screens-ingest.jsx, screens-library.jsx, screens-editor.jsx
Effort: ~1.5h
**Priority: P2 — memory leaks

## Fix Plan — #111 setTimeout/setInterval leaks across screens **Root cause:** Multiple screens fire `setTimeout`/`setInterval` outside `useEffect` or without cleanup. On unmount → `setState` on unmounted component = memory leak + console warnings. **Affected locations:** 1. `screens-ingest.jsx:214-240` — `pollRow()` recursive setTimeout from `submit()`, not useEffect 2. `screens-library.jsx:144` — setTimeout after `.then()` with no cleanup 3. `screens-library.jsx:497-505` — hover preview setTimeout fires fetch + setState 350ms later 4. `screens-editor.jsx:245` — post-save setTimeout 5. `screens-ingest.jsx:1342` — interval deps `[load, schedules]` recreate on every tick **Fix pattern — useEffect + cleanup:** ```js useEffect(() => { let cancelled = false; const timer = setTimeout(() => { if (!cancelled) doWork(); }, ms); return () => { cancelled = true; clearTimeout(timer); }; }, [deps]); ``` **Files:** `screens-ingest.jsx`, `screens-library.jsx`, `screens-editor.jsx` **Effort:** ~1.5h **Priority: P2 — memory leaks

zgaetano referenced this issue

2026-05-26 19:42:16 -04:00

Tracker: 2026-05-26 audit session — 27 bugs logged (#100-#127) #128

zgaetano closed this issue

2026-05-26 21:48:45 -04:00

zgaetano referenced this issue from a commit

2026-05-26 22:06:25 -04:00

chore: 1.2 ship-prep sweep — close 38 issues