WildDragonLLC/dragonflight
1
0
Fork 0
Code Issues 32 Pull requests 1 Projects Releases Packages Wiki Activity Actions

fix(premiere-plugin): remove broken Inno Setup [Code] heuristic

Browse source 
The Premiere-running check passed a Boolean to Exec's var ResultCode (Integer)
parameter — Pascal type error. The block also did nothing useful: it only
checked but never warned or prompted. Drop it. {InstallDelete] of the legacy
folder still works through the Tasks checkbox + Check function.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Zac Gaetano 2026-05-23 16:18:19 -04:00
parent 9266a1d471
commit 0ff2625876
1 changed files with 0 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
services/premiere-plugin/build/installer.iss
View file

@ -75,21 +75,5 @@ begin
Result := DirExists(ExpandConstant('{userappdata}\Adobe\CEP\extensions\{#LegacyBundleId}')); Result := DirExists(ExpandConstant('{userappdata}\Adobe\CEP\extensions\{#LegacyBundleId}'));
end; end;
procedure CurStepChanged(CurStep: TSetupStep);
var
PremiereRunning: Boolean;
begin
if CurStep = ssInstall then begin
PremiereRunning := False;
// Heuristic — Premiere's main exe is Adobe Premiere Pro.exe.
// If it is running, files in {app} can still be replaced (CEP loads them
// on panel open, not on Premiere launch), but the user needs a Premiere
// restart before the new bundle is picked up. Just warn, don't block.
if Exec('cmd.exe', '/C tasklist /FI "IMAGENAME eq Adobe Premiere Pro.exe" | find /I "Adobe Premiere Pro.exe" >nul', '', SW_HIDE, ewWaitUntilTerminated, PremiereRunning) and PremiereRunning then begin
// exit code 0 from `find` means the process was found
end;
end;
end;
[Run] [Run]
Filename: "{app}\README.md"; Description: "Open README"; Flags: shellexec postinstall skipifsilent unchecked Filename: "{app}\README.md"; Description: "Open README"; Flags: shellexec postinstall skipifsilent unchecked