From 0ff26258762a9305b67394b4f350a77564861683 Mon Sep 17 00:00:00 2001 From: Zac Gaetano Date: Sat, 23 May 2026 16:18:19 -0400 Subject: [PATCH] fix(premiere-plugin): remove broken Inno Setup [Code] heuristic MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Premiere-running check passed a Boolean to Exec's var ResultCode (Integer) parameter — Pascal type error. The block also did nothing useful: it only checked but never warned or prompted. Drop it. {InstallDelete] of the legacy folder still works through the Tasks checkbox + Check function. Co-Authored-By: Claude Opus 4.7 --- services/premiere-plugin/build/installer.iss | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/services/premiere-plugin/build/installer.iss b/services/premiere-plugin/build/installer.iss index 5f83ad4..492575c 100644 --- a/services/premiere-plugin/build/installer.iss +++ b/services/premiere-plugin/build/installer.iss @@ -75,21 +75,5 @@ begin Result := DirExists(ExpandConstant('{userappdata}\Adobe\CEP\extensions\{#LegacyBundleId}')); end; -procedure CurStepChanged(CurStep: TSetupStep); -var - PremiereRunning: Boolean; -begin - if CurStep = ssInstall then begin - PremiereRunning := False; - // Heuristic — Premiere's main exe is Adobe Premiere Pro.exe. - // If it is running, files in {app} can still be replaced (CEP loads them - // on panel open, not on Premiere launch), but the user needs a Premiere - // restart before the new bundle is picked up. Just warn, don't block. - if Exec('cmd.exe', '/C tasklist /FI "IMAGENAME eq Adobe Premiere Pro.exe" | find /I "Adobe Premiere Pro.exe" >nul', '', SW_HIDE, ewWaitUntilTerminated, PremiereRunning) and PremiereRunning then begin - // exit code 0 from `find` means the process was found - end; - end; -end; - [Run] Filename: "{app}\README.md"; Description: "Open README"; Flags: shellexec postinstall skipifsilent unchecked