zgaetano/dragon-wind-desktop
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: capture real S3 ETag from PUT response headers instead of placeholder
Some checks failed
Build Dragon Wind Desktop / Linux (AppImage) (push) Failing after 10s
Details
Build Dragon Wind Desktop / Create Release (push) Failing after 0s
Details

Browse source
This commit is contained in:
Zac Gaetano 2026-04-08 22:25:11 -04:00
parent 5ffbad3c65
commit fc43dffed1
1 changed files with 2 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/main/transfer-engine.js
View file

@ -232,7 +232,7 @@ class TransferEngine {
const t0 = Date.now(); const t0 = Date.now();
await this._putRequest(url, buf); const etag = await this._putRequest(url, buf); // real ETag from S3
const elapsed = (Date.now() - t0) / 1000; const elapsed = (Date.now() - t0) / 1000;
const bps = length / Math.max(elapsed, 0.001); const bps = length / Math.max(elapsed, 0.001);
@ -249,7 +249,7 @@ class TransferEngine {
job.eta = job.speedBps > 0 ? Math.round(remaining / job.speedBps) : null; job.eta = job.speedBps > 0 ? Math.round(remaining / job.speedBps) : null;
this.onProgress(this._publicJob(job)); this.onProgress(this._publicJob(job));
return `"part-${partNumber}-etag-placeholder"`; // real ETag comes from S3 response headers return etag;
} }
_putRequest(url, body) { _putRequest(url, body) {
@ -283,29 +283,6 @@ class TransferEngine {
}); });
} }
// Fix _uploadPart to capture real ETag from PUT response
async _uploadPartWithEtag(fd, offset, length, url, partNumber, job) {
const buf = Buffer.allocUnsafe(length);
fs.readSync(fd, buf, 0, length, offset);
const t0 = Date.now();
const etag = await this._putRequest(url, buf);
const elapsed = (Date.now() - t0) / 1000;
const bps = length / Math.max(elapsed, 0.001);
job._speedSamples.push(bps);
if (job._speedSamples.length > 5) job._speedSamples.shift();
job.speedBps = job._speedSamples.reduce((a, b) => a + b, 0) / job._speedSamples.length;
job.uploadedBytes += length;
job.percent = Math.round((job.uploadedBytes / job.size) * 100);
const remaining = job.size - job.uploadedBytes;
job.eta = job.speedBps > 0 ? Math.round(remaining / job.speedBps) : null;
this.onProgress(this._publicJob(job));
return etag;
}
_publicJob(job) { _publicJob(job) {
return { return {
id: job.id, id: job.id,