zgaetano/DragonWind
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix S3 config form: autofill, region default, secret field

Browse source 
- Add readonly+onfocus trick to prevent browser autofilling secret key with garbage
- Set region value="us-east-1" so it always has a real default, not just placeholder
- loadS3Config always clears secret field and sets contextual placeholder
- Secret hint now clearly shows saved vs not-saved state

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Zac Gaetano 2026-04-06 20:39:22 -04:00
parent d0525eb718
commit 017d73f48c
1 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
public/index.html
View file

@ -532,13 +532,13 @@ body::before{content:'';position:fixed;inset:0;background:radial-gradient(ellips
<div class="form-hint">For MinIO, Backblaze, Cloudflare R2, Wasabi, etc. enter the full endpoint URL. Leave blank to use standard AWS S3.</div>
</div>
<div class="form-row">
<div class="form-group"><label class="form-label">Region</label><input class="form-input" id="s3-region" type="text" placeholder="us-east-1"/></div>
<div class="form-group"><label class="form-label">Bucket Name</label><input class="form-input" id="s3-bucket" type="text" placeholder="mybucket"/></div>
<div class="form-group"><label class="form-label">Region</label><input class="form-input" id="s3-region" type="text" placeholder="us-east-1" value="us-east-1" autocomplete="off"/></div>
<div class="form-group"><label class="form-label">Bucket Name</label><input class="form-input" id="s3-bucket" type="text" placeholder="mybucket" autocomplete="off"/></div>
</div>
<div class="form-group"><label class="form-label">Access Key ID</label><input class="form-input" id="s3-access-key" type="text" autocomplete="off"/></div>
<div class="form-group"><label class="form-label">Access Key ID</label><input class="form-input" id="s3-access-key" type="text" autocomplete="off" spellcheck="false"/></div>
<div class="form-group">
<label class="form-label">Secret Access Key</label>
<input class="form-input" id="s3-secret-key" type="password" placeholder="Leave blank to keep existing" autocomplete="new-password"/>
<input class="form-input" id="s3-secret-key" type="password" placeholder="Enter new secret — leave blank to keep existing" autocomplete="off" readonly onfocus="this.removeAttribute('readonly')"/>
<div class="form-hint" id="s3-secret-hint"></div>
</div>
<div class="btn-row">
@ -1153,7 +1153,11 @@ async function loadS3Config() {
document.getElementById('s3-region').value=d.config.region||'us-east-1';
document.getElementById('s3-bucket').value=d.config.bucket||'';
document.getElementById('s3-access-key').value=d.config.accessKeyId||'';
document.getElementById('s3-secret-hint').textContent=d.config.secretKeyExists?'🔒 Secret saved — leave blank to keep.':'No secret saved.';
// Clear secret field and show status — never pre-fill passwords
const secretEl=document.getElementById('s3-secret-key');
secretEl.value='';
secretEl.placeholder=d.config.secretKeyExists?'Leave blank to keep existing secret':'Enter secret access key';
document.getElementById('s3-secret-hint').textContent=d.config.secretKeyExists?'🔒 Secret key is saved.':'⚠️ No secret saved yet.';
} catch(_) {}
}
async function testS3() {