dragonflight

WildDragonLLC/dragonflight

Fork 0

Commit graph

Author	SHA1	Message	Date
Wild Dragon Dev	01211fef7a	fix(framecache): address critical bugs from code review C-Bug 1 (Torn read): fc_client.c zero-copy pointer replaced with consumer-owned copy buffer + post-copy cursor revalidation to prevent reading torn frames when the writer laps a slow consumer. New FC_LAPPED return code. C-Bug 3 (Semaphore busy-spin): fc_client.c drains the semaphore (sem_trywait) so the count never accumulates, relying entirely on write_cursor diff for availability. Prevents 100% CPU loops + EOVERFLOW. C-Bug 4 (GET /slots stack overflow): framecache.c uses heap allocation with explicit bounds checking for JSON serialization instead of a 64KB stack buffer. C-Bug 6 (DeckLink race): decklink-bridge uses pthread_mutex_t around fc_writer calls and reopen_slot to prevent UAF/double-free from concurrent SDK callbacks. C-Bug 2-net (Resolution resync): net_ingest explicitly scales to target W:H so ffmpeg always outputs exactly frame_size bytes, ignoring source resolution changes. C-Bug 8 (strdup leak): net_ingest uses static caller-owned buffers for ffmpeg args instead of strdup across listener reconnects. C-Bug 9 (PROT_READ segfault): removed atomic write to hdr->dropped_frames from the consumer read loop (which maps shm read-only).	2026-06-03 16:25:34 +00:00
Wild Dragon Dev	99723da00f	feat(framecache): phase 5 — network ingest (RTMP/SRT) via framecache - services/framecache/src/net_ingest.c: new network ingest process - Spawns ffmpeg to decode SRT/RTMP → raw UYVY422 stdout - Reads decoded frames and writes into framecache slot via shm - Registers slot with framecache HTTP API on startup - Deregisters slot on clean exit (SIGTERM) - Reconnect loop for listener mode (stays alive between sessions) - --url, --slot-id, --fc-url, --width, --height, --fps-num/den, --source-type, --listen, --listen-port, --stream-key args - Emits format JSON to stderr on first frame - services/framecache/CMakeLists.txt: add net_ingest target - services/framecache/Dockerfile: copy net_ingest to runtime image - services/node-agent/index.js: - startNetIngest() / stopNetIngest(): lifecycle management per recorder - Spawns net_ingest before sidecar start for srt/rtmp sourceTypes - Injects FC_SLOT_ID=net-<containerId> into sidecar env - Sets IpcMode=host for network sidecars using framecache - Maps temp id → real containerId after container create - stopNetIngest() called on sidecar stop - NET_INGEST_BIN env var (default: docker exec framecache net_ingest) - services/capture/src/capture-manager.js: - _buildInputArgs srt/rtmp: framecache path when FC_SLOT_ID set (spawns fc_pipe, uses pipe:0 rawvideo input — same as SDI path) - Falls back to direct URL when FC_SLOT_ID not set (legacy path) - audioMap: network via framecache uses '0🅰️0?' (video-only fc_pipe, no audio FIFO — audio-in-shm is roadmap) - HLS tee: sdiHlsDir covers network-via-framecache; legacy tee gated on !FC_SLOT_ID to avoid duplicate HLS outputs - fc_pipe piped to ffmpeg stdin for network framecache path - docker-compose.worker.yml: FC_URL + NET_INGEST_BIN in node-agent env	2026-06-03 15:37:17 +00:00

Author

SHA1

Message

Date

Wild Dragon Dev

01211fef7a

fix(framecache): address critical bugs from code review

C-Bug 1 (Torn read): fc_client.c zero-copy pointer replaced with consumer-owned
copy buffer + post-copy cursor revalidation to prevent reading torn frames when
the writer laps a slow consumer. New FC_LAPPED return code.
C-Bug 3 (Semaphore busy-spin): fc_client.c drains the semaphore (sem_trywait)
so the count never accumulates, relying entirely on write_cursor diff for
availability. Prevents 100% CPU loops + EOVERFLOW.
C-Bug 4 (GET /slots stack overflow): framecache.c uses heap allocation with
explicit bounds checking for JSON serialization instead of a 64KB stack buffer.
C-Bug 6 (DeckLink race): decklink-bridge uses pthread_mutex_t around fc_writer
calls and reopen_slot to prevent UAF/double-free from concurrent SDK callbacks.
C-Bug 2-net (Resolution resync): net_ingest explicitly scales to target W:H
so ffmpeg always outputs exactly frame_size bytes, ignoring source resolution
changes.
C-Bug 8 (strdup leak): net_ingest uses static caller-owned buffers for ffmpeg
args instead of strdup across listener reconnects.
C-Bug 9 (PROT_READ segfault): removed atomic write to hdr->dropped_frames from
the consumer read loop (which maps shm read-only).

2026-06-03 16:25:34 +00:00

Wild Dragon Dev

99723da00f

feat(framecache): phase 5 — network ingest (RTMP/SRT) via framecache

- services/framecache/src/net_ingest.c: new network ingest process
  - Spawns ffmpeg to decode SRT/RTMP → raw UYVY422 stdout
  - Reads decoded frames and writes into framecache slot via shm
  - Registers slot with framecache HTTP API on startup
  - Deregisters slot on clean exit (SIGTERM)
  - Reconnect loop for listener mode (stays alive between sessions)
  - --url, --slot-id, --fc-url, --width, --height, --fps-num/den,
    --source-type, --listen, --listen-port, --stream-key args
  - Emits format JSON to stderr on first frame

- services/framecache/CMakeLists.txt: add net_ingest target
- services/framecache/Dockerfile: copy net_ingest to runtime image

- services/node-agent/index.js:
  - startNetIngest() / stopNetIngest(): lifecycle management per recorder
  - Spawns net_ingest before sidecar start for srt/rtmp sourceTypes
  - Injects FC_SLOT_ID=net-<containerId> into sidecar env
  - Sets IpcMode=host for network sidecars using framecache
  - Maps temp id → real containerId after container create
  - stopNetIngest() called on sidecar stop
  - NET_INGEST_BIN env var (default: docker exec framecache net_ingest)

- services/capture/src/capture-manager.js:
  - _buildInputArgs srt/rtmp: framecache path when FC_SLOT_ID set
    (spawns fc_pipe, uses pipe:0 rawvideo input — same as SDI path)
  - Falls back to direct URL when FC_SLOT_ID not set (legacy path)
  - audioMap: network via framecache uses '0🅰️0?' (video-only fc_pipe,
    no audio FIFO — audio-in-shm is roadmap)
  - HLS tee: sdiHlsDir covers network-via-framecache; legacy tee gated
    on !FC_SLOT_ID to avoid duplicate HLS outputs
  - fc_pipe piped to ffmpeg stdin for network framecache path

- docker-compose.worker.yml: FC_URL + NET_INGEST_BIN in node-agent env

2026-06-03 15:37:17 +00:00

2 commits