From 72545126c42a616c2e31dfa0a9372d8fea92970b Mon Sep 17 00:00:00 2001
From: Zac <zgaetano@wilddragon.net>
Date: Sun, 17 May 2026 12:55:36 -0400
Subject: [PATCH] fix: delete asset actually deletes

Trash icon in the library was firing PATCH /assets/:id with {status:"deleted"}. The PATCH route only accepts display_name/tags/notes so it returned "No fields to update" and the asset stayed put.

* api.js: add deleteAsset(id, {hard}) helper hitting the real DELETE route.
* index.html: deleteAssetPrompt now calls deleteAsset (soft archive). Confirm dialog reworded to match.
* mam-api/routes/assets.js: list endpoint hides status=archived by default. Pass ?include_archived=true to see them in a future restore-from-trash view. Filtering by ?status=archived still works for power users.
* All HTML: bump api.js cache-buster v=4 -> v=5 so the new helper is fetched.
---
 services/mam-api/src/routes/assets.js | 7 +++++++
 services/web-ui/public/capture.html   | 2 +-
 services/web-ui/public/index.html     | 6 +++---
 services/web-ui/public/js/api.js      | 5 +++++
 services/web-ui/public/player.html    | 2 +-
 services/web-ui/public/recorders.html | 2 +-
 services/web-ui/public/upload.html    | 2 +-
 7 files changed, 19 insertions(+), 7 deletions(-)

diff --git a/services/mam-api/src/routes/assets.js b/services/mam-api/src/routes/assets.js
index 0459e72..890a03e 100644
--- a/services/mam-api/src/routes/assets.js
+++ b/services/mam-api/src/routes/assets.js
@@ -30,6 +30,7 @@ router.get('/', async (req, res, next) => {
       media_type,
       limit = 50,
       offset = 0,
+      include_archived,
     } = req.query;
 
     let query = `
@@ -41,6 +42,12 @@ router.get('/', async (req, res, next) => {
     const params = [];
     let paramCount = 1;
 
+    // Hide archived rows unless explicitly asked for, or unless the caller is
+    // already filtering by status=archived.
+    if (!status && include_archived !== 'true') {
+      query += ` AND a.status <> 'archived'`;
+    }
+
     if (project_id) {
       query += ` AND a.project_id = $${paramCount++}`;
       params.push(project_id);
diff --git a/services/web-ui/public/capture.html b/services/web-ui/public/capture.html
index eb3c9ea..b61892c 100644
--- a/services/web-ui/public/capture.html
+++ b/services/web-ui/public/capture.html
@@ -312,7 +312,7 @@
 
 <div class="toast-container" id="toastContainer" aria-live="polite"></div>
 
-<script src="js/api.js?v=4"></script>
+<script src="js/api.js?v=5"></script>
 <script>
   const cState = {
     devices: [],
diff --git a/services/web-ui/public/index.html b/services/web-ui/public/index.html
index 7b12b81..b284bab 100644
--- a/services/web-ui/public/index.html
+++ b/services/web-ui/public/index.html
@@ -457,7 +457,7 @@
   </div>
 </div>
 
-<script src="js/api.js?v=4"></script>
+<script src="js/api.js?v=5"></script>
 <script src="js/preview.js?v=1"></script>
 <script>
   const state = {
@@ -668,8 +668,8 @@
 
   async function deleteAssetPrompt(id, e) {
     e.stopPropagation();
-    if (!confirm('Delete this asset? This cannot be undone.')) return;
-    const r = await updateAsset(id, { status: 'deleted' });
+    if (!confirm('Delete this asset? It will be archived and hidden from the library.')) return;
+    const r = await deleteAsset(id);
     if (r.success) { toast('Asset deleted', '', 'success'); loadAssets(); }
     else toast('Delete failed', r.error, 'error');
   }
diff --git a/services/web-ui/public/js/api.js b/services/web-ui/public/js/api.js
index b7bff9e..a5cbbcb 100644
--- a/services/web-ui/public/js/api.js
+++ b/services/web-ui/public/js/api.js
@@ -106,6 +106,11 @@ async function getAssetMetadata(assetId) {
     return api(`/assets/${assetId}`);
 }
 
+async function deleteAsset(assetId, { hard = false } = {}) {
+    const qs = hard ? '?hard=true' : '';
+    return api(`/assets/${assetId}${qs}`, { method: 'DELETE' });
+}
+
 // ============================================================
 // PROJECT API CALLS
 // ============================================================
diff --git a/services/web-ui/public/player.html b/services/web-ui/public/player.html
index a8c08d0..04484c5 100644
--- a/services/web-ui/public/player.html
+++ b/services/web-ui/public/player.html
@@ -304,7 +304,7 @@
         </footer>
     </div>
 
-    <script src="/js/api.js?v=4"></script>
+    <script src="/js/api.js?v=5"></script>
     <script>
         // ============================================================
         // STATE MANAGEMENT
diff --git a/services/web-ui/public/recorders.html b/services/web-ui/public/recorders.html
index 2f59174..159c9b7 100644
--- a/services/web-ui/public/recorders.html
+++ b/services/web-ui/public/recorders.html
@@ -357,7 +357,7 @@
 
 <div class="toast-container" id="toastContainer" aria-live="polite"></div>
 
-<script src="js/api.js?v=4"></script>
+<script src="js/api.js?v=5"></script>
 <script>
   const pState = { recorders: [], timers: {}, sourceType: 'srt', mode: 'caller', projects: [], signals: {} };
 
diff --git a/services/web-ui/public/upload.html b/services/web-ui/public/upload.html
index 2000bbc..30ba5ee 100644
--- a/services/web-ui/public/upload.html
+++ b/services/web-ui/public/upload.html
@@ -249,7 +249,7 @@
 
 <div class="toast-container" id="toastContainer" aria-live="polite"></div>
 
-<script src="js/api.js?v=4"></script>
+<script src="js/api.js?v=5"></script>
 <script>
   const CHUNK = 10 * 1024 * 1024; // 10 MB chunks
   const state = { projects: [], bins: [], queue: [], uploading: false };